I am not remotely a legal expert - especially not on Pennsylvania, where I've only ever spent enough time to get confused about how to buy beer - but I do want to be sure I've presented my thoughts/guesses clearly. What I'm suggesting is that because of the enclosed nature of the pictured holster, the gun could be considered concealed - so open carry laws would not apply. Instead, in order to carry in that holster one might need a LTCF. I expect that if I've totally blown it here someone who knows better will let me know!
Again, I hope you'll pardon my pedantry, I just think it's important that as gun owners we get all our t's crossed and i's dotted when it comes to legality and the ways we present ourselves in public.